wpfshadergenerator Issue Tracker Rss Feed

Closed Issue: URI not correctly generated [6148]

sbussinger — Thu, 16 May 2013 05:05:35 GMT

The "pixelShader.UriSource" statement in the generated constructor isn't generating the correct URI for the pixel shader.

Given a project folder structure like:

Opto.Imaging\
Effects\
OptoImagingEffect.fx

The generated URI looks like:

pixelShader.UriSource = new Uri("/Opto.Imaging;component/Imaging/Effects/OptoImagingEffect.ps", UriKind.Relative);

The "Imaging" in the middle of that URI shouldn't be there.

If I add a Custom Tool Namespace of "Opto.Imaging", the generated code looks like:

pixelShader.UriSource = new Uri("/Opto.Imaging;component/Imaging/OptoImagingEffect.ps", UriKind.Relative);

The Imaging in the in middle of the URI should be "Effects".

Created Issue: Does not generate correct C# file for Silverlight [7120]

carlsverre — Tue, 17 Aug 2010 22:33:24 GMT

When setting the build target for silverlight there are two errors in the resulting .cs file:

Error 1:
Your DependencyProperty declaration should use PropertyMetaData rather than UIPropertyMetadata. Ie:

This line:
public static readonly DependencyProperty TintColorProperty = DependencyProperty.Register("TintColor", typeof(System.Windows.Media.Color), typeof(ColorTinter), new UIPropertyMetadata(Color.FromArgb(0,0,0,0), PixelShaderConstantCallback(0)));

Should be:

public static readonly DependencyProperty TintColorProperty = DependencyProperty.Register("TintColor", typeof(System.Windows.Media.Color), typeof(ColorTinter), new PropertyMetadata(Color.FromArgb(0,0,0,0), PixelShaderConstantCallback(0)));

Error 2:

The Uri source should be changed to a relative url:

From this:
pixelShader.UriSource = new Uri("pack://application:,,,/SparkPlug;component/sparkplug/fx/ColorTinter.ps", UriKind.Absolute);

To this:
pixelShader.UriSource = new Uri("/SparkPlug;component/sparkplug/fx/ColorTinter.ps", UriKind.Relative);

There might be another fix for the second problem, but the fix I described works for me.

Created Issue: can't handle float or double unless they have integer value. [7115]

ThomasPetersson — Tue, 17 Aug 2010 13:41:48 GMT

When a default value containg a ".", such as <defaultValue>1.5</defaultValue>, is specified for type double or float, the generated code sets "0". With an integer value it works correctly however!

Commented Issue: Eliminate need for updating DirectX Runtime [7103]

sbussinger — Fri, 13 Aug 2010 00:32:34 GMT

It would be nice if you borrowed the technique used by Shazzam to eliminate the need for installing/updating the DirectX Runtime. While the existing technique is a huge improvement over installing the DirectX SDK, Shazzam's technique of just embedding the D3DCompiler is even better from an installation point of view. Removing the need to update the DirectX runtime everytime you want to install/update the ShaderEffect Generator would be make the process much faster.
Comments: ** Comment from web user: sbussinger **

Thanks Nick!

Commented Issue: Eliminate need for updating DirectX Runtime [7103]

NickDarnell — Thu, 12 Aug 2010 22:40:23 GMT

I will give it a try for the release after 1.7 :)

Created Issue: Eliminate need for updating DirectX Runtime [7103]

sbussinger — Thu, 12 Aug 2010 16:19:47 GMT

Commented Issue: tag not honored in generated code [6147]

NickDarnell — Thu, 12 Aug 2010 03:52:39 GMT

If I have a constant register defined like this:

/// <defaultValue>1</defaultValue>
float isEnabled : register(C0);

The generated dependency property looks like:

public static readonly DependencyProperty IsEnabledProperty =
DependencyProperty.Register("IsEnabled", typeof(System.Double), typeof(OptoImagingEffect),
new UIPropertyMetadata((double)0, PixelShaderConstantCallback(0)));

Note that the default is "(double)0" and should be "(double)1".
Comments: ** Comment from web user: NickDarnell **

This should be fixed in the version after 1.61.

Commented Issue: URI not correctly generated [6148]

sbussinger — Sat, 17 Apr 2010 17:13:20 GMT

I wanted to follow up and let you know that your fix worked great! Thank you very much Nick!

Commented Issue: URI not correctly generated [6148]

Thecentury — Thu, 15 Apr 2010 13:59:25 GMT

Thank you, Nick, for your great work!

Commented Issue: URI not correctly generated [6148]

NickDarnell — Thu, 15 Apr 2010 13:31:05 GMT

Thanks for reporting the issue guys. I have a fix I should be able to post a new version later tonight.

Commented Issue: URI not correctly generated [6148]

Thecentury — Thu, 15 Apr 2010 05:25:22 GMT

I have a DynamicDataDisplay.Maps.dll with default namespace Microsoft.Research.DynamicDataDisplay.Maps. If we have shader in the root of the project, then it is possible to use the following URI: new Uri("pack://application:,,,/DynamicDataDisplay.Maps;component/ConvolutionEffect.ps") instead of the uri that is generated by your addin - new Uri("/DynamicDataDisplay.Maps;component/Research/DynamicDataDisplay/Maps/ConvolutionEffect.ps", UriKind.Relative).

Created Issue: URI not correctly generated [6148]

sbussinger — Mon, 08 Mar 2010 00:46:46 GMT

Created Issue: tag not honored in generated code [6147]

sbussinger — Mon, 08 Mar 2010 00:35:27 GMT

Commented Issue: Add support for tag in HLSL markup [6126]

sbussinger — Mon, 08 Mar 2010 00:23:33 GMT

Shazzam uses a <namespace> tag to override the default namespace in the generated *.CS file. This project seems to always use the location in the project for the namespace. I'd really like the ability to override the defaults. For example the current default may be something like Test.Imaging.Effects, but I'd like to change it to Test.Imaging to keep the number of namespaces under control.
Comments: ** Comment from web user: sbussinger **

Thanks! I'd never paid any attention to that setting before. Good to know it's there and it seemed to work fine. It would be nice to go ahead and support the <namespace> tag if only to keep this project and Shazzam in sync, but it's certainly a very low priority given the "Custom Tool Namespace" property.

Commented Issue: Add support for tag in HLSL markup [6126]

NickDarnell — Fri, 05 Mar 2010 06:18:36 GMT

In visual studio, you can set the "Custom Tool Namespace" property on the file. That will override the default one I pick based on the file location.

Created Issue: Add support for tag in HLSL markup [6126]

sbussinger — Thu, 04 Mar 2010 21:01:45 GMT